[jdk20] RFR: 8299689: Make use of JLine for Console as "opt-in" [v2]

Naoto Sato naoto at openjdk.org
Mon Jan 9 17:09:30 UTC 2023


On Sat, 7 Jan 2023 10:35:50 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addressing review suggestions
>
> src/java.base/share/classes/jdk/internal/io/JdkConsoleProvider.java line 35:
> 
>> 33:  * designates the module name of the implementation, and which defaults
>> 34:  * to "java.base". If no providers is available,
>> 35:  * or instantiation failed, java.base built-in Console implementation
> 
> The overall change looks fine but I think for the next edit that we should move most of this comment to Console as it's Console that selects the behavior and that skips errors. Also once the SM execution mode goes away then we can re-visit that behavior.

Makes sense. The comment has been moved to `Console`.

-------------

PR: https://git.openjdk.org/jdk20/pull/88


More information about the core-libs-dev mailing list