RFR: JDK-8262994: Refactor String.split to help method inlining [v2]

Christian Wimmer cwimmer at openjdk.org
Mon Jan 9 20:04:36 UTC 2023


On Tue, 27 Dec 2022 23:36:52 GMT, Ismael Juma <duke at openjdk.org> wrote:

>> Christian Wimmer has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add comment about method inlining
>
> src/java.base/share/classes/java/lang/String.java line 3133:
> 
>> 3131:         {
>> 3132:             // All the checks above can potentially be constant folded by
>> 3133:             // a JIT/AOT compiler when the regex is a constant string.
> 
> Probably worth mentioning explicitly that the private `split` was extracted to help with inlining (to reduce the probability of future regressions).

I extended the comment

-------------

PR: https://git.openjdk.org/jdk/pull/11791


More information about the core-libs-dev mailing list