RFR: 8299513: Cleanup java.io [v4]
Sergey Bylokhov
serb at openjdk.org
Tue Jan 10 00:28:55 UTC 2023
On Mon, 9 Jan 2023 08:57:11 GMT, Per Minborg <pminborg at openjdk.org> wrote:
>> Code in java.io contains many legacy constructs and semantics not recommended including:
>>
>> * C-style array declaration
>> * Unnecessary visibility
>> * Redundant keywords in interfaces (e.g. public, static)
>> * Non-standard naming for constants
>> * Javadoc typos
>> * Missing final declaration
>>
>> These should be fixed as a sanity effort.
>
> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
>
> Add additional (c) years
src/java.base/share/classes/java/io/DataInputStream.java line 582:
> 580: * @see java.io.DataInputStream#readUnsignedShort()
> 581: */
> 582: public static String readUTF(DataInput in) throws IOException {
I remember a few years ago asked to create a CCC to remove the final keyword in the final class. This change seems broader, probably the rules are changed since then, but this one actually may affect the method signature. And subclasses will allow hiding this method.
-------------
PR: https://git.openjdk.org/jdk/pull/11848
More information about the core-libs-dev
mailing list