RFR: 8299513: Cleanup java.io [v5]

Per Minborg pminborg at openjdk.org
Tue Jan 10 15:55:59 UTC 2023


On Tue, 10 Jan 2023 14:59:35 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert removal of a final keyword
>
> src/java.base/share/classes/java/io/ObjectStreamConstants.java line 38:
> 
>> 36:      * Magic number that is written to the stream header.
>> 37:      */
>> 38:     short STREAM_MAGIC = (short)0xaced;
> 
> I'd prefer to retain the `static`, it is easier to read and not have to remember that this declaration is in an interface.

I think the class should not be an interface in the first place but this is hard to change now.

-------------

PR: https://git.openjdk.org/jdk/pull/11848


More information about the core-libs-dev mailing list