RFR: 8299513: Clean up java.io [v7]

[Andrey Turbanov]

On Wed, 11 Jan 2023 09:13:28 GMT, Per Minborg <pminborg at openjdk.org> wrote:

>> Code in java.io contains many legacy constructs and semantics not recommended including: 
>> 
>> * C-style array declaration 
>> * Unnecessary visibility 
>> * Redundant keywords in interfaces (e.g. public, static) 
>> * Non-standard naming for constants 
>> * Javadoc typos 
>> * Missing final declaration 
>> 
>> These should be fixed as a sanity effort.
>
> Per Minborg has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update src/java.base/share/classes/java/io/ObjectStreamConstants.java
>    
>    Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>  - Clean up ObjectStreamConstants

src/java.base/share/classes/java/io/ObjectStreamConstants.java line 108:

> 106:      * number of bytes in this block data.
> 107:      */
> 108:     static byte TC_BLOCKDATALONG= 0x7A;

Add space before `=`
Suggestion:

    static byte TC_BLOCKDATALONG = 0x7A;

src/java.base/share/classes/java/io/ObjectStreamConstants.java line 139:

> 137:      * First wire handle to be assigned.
> 138:      */
> 139:     static int BASE_WIRE_HANDLE = 0x7e0000;

Isn't it a part of public API? You shouldn't rename such things in cleanup PRs.

https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/io/ObjectStreamConstants.html#baseWireHandle

-------------

PR: https://git.openjdk.org/jdk/pull/11848