RFR: 8299513: Clean up java.io [v8]
Andrey Turbanov
aturbanov at openjdk.org
Wed Jan 11 10:40:17 UTC 2023
On Wed, 11 Jan 2023 09:22:24 GMT, Per Minborg <pminborg at openjdk.org> wrote:
>> Code in java.io contains many legacy constructs and semantics not recommended including:
>>
>> * C-style array declaration
>> * Unnecessary visibility
>> * Redundant keywords in interfaces (e.g. public, static)
>> * Non-standard naming for constants
>> * Javadoc typos
>> * Missing final declaration
>>
>> These should be fixed as a sanity effort.
>
> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
>
> Revert renaming
src/java.base/share/classes/java/io/DataInputStream.java line 2:
> 1: /*
> 2: * Copyright (c) 1994, 2023, Oracle and/or its affiliates. All rights reserved.
Only copyright year is updated in this file?
src/java.base/share/classes/java/io/ExpiringCache.java line 41:
> 39: // Clear out old entries every few queries
> 40: private int queryCount;
> 41: private final int queryOverflow = 300;
can it be made `static` too?
-------------
PR: https://git.openjdk.org/jdk/pull/11848
More information about the core-libs-dev
mailing list