RFR: 8177418: NPE is not apparent for methods in java.util.TimeZone API docs [v4]

Justin Lu duke at openjdk.org
Fri Jan 13 21:14:45 UTC 2023


> When their input is null, the following methods in java.util.TimeZone throw a NullPointerException:
> 
> TimeZone.getTimeZone(String ID)
> TimeZone.setID(String ID)
> TimeZone.inDaylightTime(Date date)
> 
> For example, 
> 
> 
> String someID = null;
> TimeZone tz1 = TimeZone.getTimeZone(someID);
> ``` 
> 
> throws a `NullPointerException`
> 
> However this is not documented in the API docs in the form of a _throws:_ section.
> 
> This change updates the documentation to make this apparent.
> 
> Aditionally, updates the javadoc of SimpleTimeZone.inDaylightTime(Date date) to inherit the _ at throws:_

Justin Lu has updated the pull request incrementally with one additional commit since the last revision:

  Change @ throws to account for external subclassing of TimeZone

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/11888/files
  - new: https://git.openjdk.org/jdk/pull/11888/files/ae49f170..a8059d50

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11888&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11888&range=02-03

  Stats: 3 lines in 2 files changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/11888.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11888/head:pull/11888

PR: https://git.openjdk.org/jdk/pull/11888


More information about the core-libs-dev mailing list