RFR: 8299502: Usage of constructors of primitive wrapper classes should be avoided in javax.xml API docs [v2]

altrisi duke at openjdk.org
Sat Jan 14 13:33:15 UTC 2023


On Fri, 6 Jan 2023 21:59:13 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> Removed constructors of primitive wrapper classes (deprecated for removal) in _javax.xml.stream.XMLOutputFactory_ 
>> 
>> Replaced with Boolean static fields: Boolean.TRUE and Boolean.FALSE
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Replace | with single value in example

I'd say in there it makes more sense given the method is used when you want a wrapper, and therefore explicitly converting it helps documentation, but here it's just setting a property, where I don't think it helps anything, just decreases readability as it seems like there may be a reason to call it explicitly with a wrapper and not a simple `true`/`false`.

-------------

PR: https://git.openjdk.org/jdk/pull/11872


More information about the core-libs-dev mailing list