RFR: 8300228: ModuleReader.find on exploded module throws if resource name maps to invalid file path

Alan Bateman alanb at openjdk.org
Tue Jan 17 14:13:14 UTC 2023


On Tue, 17 Jan 2023 12:34:31 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Should we also add a `C:/java` (one with a forward slash) to the new junk resource names added in this test, to exercise the path where a forward slash is present in a resource name which also has the Windows disallowed `:` character in it?

C:/java is a legal file path so there wouldn't be InvalidPathException for that case. The reason that resource name will be rejected on Windows is because it has a root component.  So yes, it could be added as a test case, just wouldn't add any more test coverage to the existing tests.

-------------

PR: https://git.openjdk.org/jdk/pull/12035


More information about the core-libs-dev mailing list