RFR: 8292635: Improve CDSHeapVerifier testing [v2]

[David Holmes]

On Tue, 17 Jan 2023 17:40:33 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Moving the `ArchivedEnumTest.java` from `runtime/cds/appcds/cacheObject` to `jdk/internal/misc/CDS` so that the test will be run in jdk-tier1. This is to avoid inadvertently breakage of the test like in JDK-8292499.
>> 
>> Testing: jdk-tier1, tier3, tier4.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   enable CDSHeapVerifier::verify() for non-debug build

I'm a bit confused. The JBS issue lists two things to do to improve verification, but all this PR seems to do is move the test - in which case the JBS issue should be updated.

This PR also changes the verification logic to be available in product builds - presumably because JDK testing uses product builds not debug ones - but this is not mentioned. Can I assume this change in itself has no impact unless verification is explicitly requested?

-------------

PR: https://git.openjdk.org/jdk/pull/11999