RFR: 8300487: Store cardinality as a field in BitSet [v5]

[Alan Bateman]

On Wed, 18 Jan 2023 12:43:31 GMT, fabioromano1 <duke at openjdk.org> wrote:

>> The enanchment is useful for applications that make heavy use of BitSet objects as sets of integers, and therefore they need to make a lot of calls to cardinality() method, which actually require linear time in the number of words in use by the bit set.
>> This optimization reduces the cost of calling cardinality() to constant time, as it simply returns the value of the field, and it also try to make as little effort as possible to update the field, when needed.
>> 
>> Moreover, it has been implemented a new method for testing wheter a bit set includes another bit set (i.e., the set of true bits of the parameter is a subset of the true bits of the instance).
>
> fabioromano1 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added author and reverse the cicle order in includes(BitSet)

As others have said, I think this will need a set of benchmarks to see what the impact, if any, on other methods.

Also I think it would be better to separate out the proposal to add includes(BitSet) as that is a different issue to the cardinality method.

-------------

PR: https://git.openjdk.org/jdk/pull/11837