RFR: 8300693: Lower the compile threshold and reduce the iterations of warmup loop in VarHandles tests [v2]

Mandy Chung mchung at openjdk.org
Fri Jan 20 17:45:47 UTC 2023


On Fri, 20 Jan 2023 04:53:10 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Mandy Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   move the comment to @comment
>
> test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessBoolean.java line 284:
> 
>> 282: 
>> 283:     // CompileThresholdScaling is set to 0.1 and ITERS to 2000 to reduce
>> 284:     // the test execution
> 
> Wouldn't this be clearer as an `@comment` in the test header prior to the `@run` statements that use the variables?

Good suggestion.  Updated.

-------------

PR: https://git.openjdk.org/jdk/pull/12104


More information about the core-libs-dev mailing list