RFR: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface [v4]

Sergey Bylokhov serb at openjdk.org
Sat Jan 21 19:35:14 UTC 2023


On Wed, 18 Jan 2023 22:06:55 GMT, Tagir F. Valeev <tvaleev at openjdk.org> wrote:

>> Tagir F. Valeev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>> 
>>  - Copyright year and @since tag updated
>>  - Fixes according to review
>>    
>>    1. Reduce duplication in tests
>>    2. Use JumpableGenerator#copy() instead of create(1) in tests, as according to the spec, seed can be ignored
>>    3. Simplify documentation for shuffle(List, Random) to avoid duplication.
>>  - Remove Random -> ThreadLocalRandom change
>>  - 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface
>
> Hm... is something still missing?

@amaembo please fix that

 === Output from failing command(s) repeated here ===
* For target jdk_modules_java.base__the.java.base_batch:

-------------

PR: https://git.openjdk.org/jdk/pull/10520


More information about the core-libs-dev mailing list