RFR: 8299444 java.util.Set.copyOf allocates needlessly for empty input collections [v2]

[Stuart Marks]

On Tue, 24 Jan 2023 19:34:48 GMT, Viktor Klang <duke at openjdk.org> wrote:

>> Thanks @szegedi for catching this and @viktorklang-ora for fixing it. I like having comments like this in cases where we need to throw NPE for null and for which there's no explicit `Objects.requireNonNull`. We've had cases in the past where an apparently innocuous refactoring postponed an implicit nullcheck, which opened the possibility of a side effect occuring before NPE was thrown (violates failure idempotency). So I think maintaining such comments is important.
>> 
>> With that in mind, for the Set and Map cases, could you (Viktor) add similar comments there? Arguably they should have been there already, but, oh well, they weren't. Thanks.
>
> @stuart-marks Makes sense. I've added those comments to Set and Map copyOf()

Great, thanks!

-------------

PR: https://git.openjdk.org/jdk/pull/11847