RFR: 8300916: Re-examine the initialization of JNU Charset in StaticProperty [v3]

Naoto Sato naoto at openjdk.org
Tue Jan 24 21:57:25 UTC 2023


> This issue was found during the review of this PR: https://github.com/openjdk/jdk/pull/12132 where `Charset` class was loaded/initialized at the phase 1 of the startup process. Since `Charset` depends on `StaticProperty`, loading of `Charset` class should be delayed. I basically moved cache for `jnuCharset` into the actual calling locations `ProcessImpl` and `ProcessEnvironment` for unix platforms so that initPhase1() won't initialize `Charset` class.
> Unrelated, but I replaced `Locale.ENGLISH` with `Locale.ROOT` in the argument of `toLowerCase()`.

Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:

  One more.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12171/files
  - new: https://git.openjdk.org/jdk/pull/12171/files/579aca70..23ed827c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12171&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12171&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/12171.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12171/head:pull/12171

PR: https://git.openjdk.org/jdk/pull/12171


More information about the core-libs-dev mailing list