RFR: 8177418: NPE is not apparent for methods in java.util.TimeZone API docs [v7]
Justin Lu
jlu at openjdk.org
Wed Jan 25 20:02:46 UTC 2023
On Wed, 25 Jan 2023 19:55:09 GMT, Lance Andersen <lancea at openjdk.org> wrote:
>> In the CSR, Joe brought up the point that since _Time Zone_ is a non final class, and these instance methods can be overridden, there exists the possibility of an external subclass that overrides the method and does **not** throw an NPE. That is why in the @throws: section, the wording is weakened from _will_ throw an NPE to _may._
>>
>> The **@ImplSpec** is then added on to state that Time Zone's default implementation of the particular method _does_ indeed throw an NPE.
>
> OK, fair enough, let's get the CSR moving forward to make sure the proposed wording addresses Joe's concern.
Agreed, was planning to finalize the CSR before the end of the day, and will adjust this accordingly if Joe has concerns
-------------
PR: https://git.openjdk.org/jdk/pull/11888
More information about the core-libs-dev
mailing list