RFR: 8300916: Re-examine the initialization of JNU Charset in StaticProperty [v8]

Naoto Sato naoto at openjdk.org
Thu Jan 26 00:14:17 UTC 2023


On Wed, 25 Jan 2023 23:58:41 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Restored doPriv
>
> src/java.base/share/classes/java/nio/charset/Charset.java line 662:
> 
>> 660:                 } else {
>> 661:                     PrivilegedAction<Charset> pa =
>> 662:                         () -> standardProvider.charsetForName(StaticProperty.fileEncoding());
> 
> what operation does this do security permission check?  I don't think any.

Right. I was under the impression that the call should have been made with privileged action (as in the comments for those access methods in `StaticProperty`, but the property value itself is not given to untrusted code. Will remove the permission check.

-------------

PR: https://git.openjdk.org/jdk/pull/12171


More information about the core-libs-dev mailing list