RFR: JDK-8300808: Accelerate Base64 on x86 for AVX2 [v6]
Claes Redestad
redestad at openjdk.org
Fri Jan 27 22:24:25 UTC 2023
On Fri, 27 Jan 2023 21:36:29 GMT, Claes Redestad <redestad at openjdk.org> wrote:
>> Scott Gibbons has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision:
>>
>> - Merge branch 'openjdk:master' into Base64-AVX2
>> - Merge branch 'openjdk:master' into Base64-AVX2
>> - Merge branch 'openjdk:master' into Base64-AVX2
>> - Merge branch 'Base64-AVX2' of https://github.com/asgibbons/jdk into Base64-AVX2
>> - Merge branch 'openjdk:master' into Base64-AVX2
>> - Address review comment
>> - Remove whitespace
>> - Fix wrong register usage
>> - Working version of Base64 decode with AVX2 (4x perf improvement). No URL support
>> - Merge branch 'Base64-AVX2' of https://github.com/asgibbons/jdk into Base64-AVX2
>> - ... and 3 more: https://git.openjdk.org/jdk/compare/50dc1196...3e66f7be
>
> src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 2643:
>
>> 2641: // Handle isURL / MIME?!?! r12 is used for length calculation (from out)
>> 2642: //
>> 2643: // rbx is out, r12 is saved out, rdx is size, rsi is src
>
> It seems that on windows `r12` is in use, see line 2323. GHA seem to be having some trouble finishing Windows testing on time - could there be some issue here?
Nevermind, you're not using r12 and GHA Windows testing is green now.
-------------
PR: https://git.openjdk.org/jdk/pull/12126
More information about the core-libs-dev
mailing list