RFR: 8310929: Optimization for Integer.toString [v10]

温绍锦 duke at openjdk.org
Sun Jul 2 01:59:13 UTC 2023


On Sun, 2 Jul 2023 01:27:26 GMT, Chen Liang <liach at openjdk.org> wrote:

>> 温绍锦 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use upper case for static final field
>
> src/java.base/share/classes/java/lang/StringUTF16.java line 1538:
> 
>> 1536:                 0x300039, 0x310039, 0x320039, 0x330039, 0x340039, 0x350039, 0x360039, 0x370039, 0x380039, 0x390039
>> 1537:         };
>> 1538:         if (isBigEndian()) {
> 
> If the digits always have to adapt to the endianness on initialization, should we just initialize this packed digits array to endianness and remove the endianness boolean in putInt/LongUnaligned?

here is the endianness of each char, and putIntUnaligned is the endianness of the entire int

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14699#discussion_r1249086284


More information about the core-libs-dev mailing list