RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v21]

[Oliver Kopp]

On Wed, 5 Jul 2023 23:37:28 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Oliver Kopp has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 30 commits:
>> 
>>  - Merge remote-tracking branch 'upstream/master' into fix-8240567
>>  - Reformat
>>  - Update test/jdk/tools/jlink/JLink100Modules.java
>>    
>>    Co-authored-by: Mandy Chung <mandy.chung at oracle.com>
>>  - Refine test to fill DedupSetBuilder
>>  - Merge remote-tracking branch 'upstream/master' into fix-8240567
>>  - Replace non-final wrapper by local variable
>>  - Update src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java
>>    
>>    Co-authored-by: Mandy Chung <mandy.chung at oracle.com>
>>  - Update src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java
>>    
>>    Co-authored-by: Mandy Chung <mandy.chung at oracle.com>
>>  - Update src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java
>>    
>>    Co-authored-by: Mandy Chung <mandy.chung at oracle.com>
>>  - Refine comment
>>    
>>    Co-authored-by: Mandy Chung <mandy.chung at oracle.com>
>>  - ... and 20 more: https://git.openjdk.org/jdk/compare/66d27365...e112f03a
>
> test/jdk/tools/jlink/JLink100Modules.java line 75:
> 
>> 73:             for (int j = 0; j < i % 20; j++) {
>> 74:                 moduleInfoContent.append("  requires module" + j + "x;\n");
>> 75:             }
> 
> Do you want to keep this change?   or at least take out the comment since this doesn't feed DedupSetBuilder.
> 
> Can you add a comment about "the numbers cannot be arbitrarily increased".

I reverted at [`8494517` (#14408)](https://github.com/openjdk/jdk/pull/14408/commits/8494517103c7b303e28c8a8e15fab951b9ea28ea). Think, the comment is then not necessary?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14408#discussion_r1253771020