RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v2]

[sid8606]

On Fri, 7 Jul 2023 12:15:39 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> sid8606 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address Amit's review comments
>
> src/hotspot/cpu/s390/upcallLinker_s390.cpp line 141:
> 
>> 139: 
>> 140:   // The Java call uses the JIT ABI, but we also call C.
>> 141:   int out_arg_area = MAX2(frame::z_jit_out_preserve_size + arg_shuffle.out_arg_bytes(), (int)frame::z_abi_160_size);
> 
> What do you mean here with "but we also call C"? Upcall stubs are always calling into Java, though the source ABI is unknown.

We do native calls in this stub, so make sure allocated stack is big enough.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1255953719