RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v2]

sid8606 duke at openjdk.org
Fri Jul 7 18:28:56 UTC 2023


On Fri, 7 Jul 2023 17:55:35 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Since  s390x runs in Big Endian mode. We get LSB on higher address of integer size.
>
> Ah, wait, now I see. The native side uses `int` as a type, but we try to load it as a `JAVA_BYTE`. I think this is a bug in the test. The Java side should use `JAVA_INT` instead, and the size passed to `reinterpret` should be `4` (which matches the native type). What happens if you make that change instead? Does the test pass then?

Yes, it does pass the test with above changes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1256271583


More information about the core-libs-dev mailing list