RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v2]

[sid8606]

On Fri, 7 Jul 2023 12:02:33 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> sid8606 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address Amit's review comments
>
> src/hotspot/cpu/s390/downcallLinker_s390.cpp line 207:
> 
>> 205:   __ z_lg(callerSP, _z_abi(callers_sp), Z_SP); // preset (used to access caller frame argument slots)
>> 206:   __ block_comment("{ argument shuffle");
>> 207:   arg_shuffle.generate(_masm, as_VMStorage(callerSP), frame::z_jit_out_preserve_size, _abi._shadow_space_bytes, locs);
> 
> I'm not sure exactly what `callerSP` is doing, but it seems to be Z_SP + bias? Why can't the `in_stk_bias` parameter be used for that? (and then use `tmp` for the shuffle reg).

Here we saving the caller frame i.e java stack pointer to use in Argument shuffling, I made the changes to use frame pointer Z_R11 now. hence removed this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1257229839