RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v2]
sid8606
duke at openjdk.org
Mon Jul 10 16:31:18 UTC 2023
On Fri, 7 Jul 2023 12:24:10 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> sid8606 has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Address Amit's review comments
>
> src/hotspot/cpu/s390/upcallLinker_s390.cpp line 243:
>
>> 241: case T_CHAR:
>> 242: case T_INT:
>> 243: __ z_lgfr(Z_RET, Z_RET); // Clear garbage in high half.
>
> Same as PPC here; this should really be done on the Java side. (See: https://github.com/openjdk/jdk/pull/12708#issuecomment-1440433079 and related discussion)
I plan to fix it later once done with experiments with this.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1258555188
More information about the core-libs-dev
mailing list