RFR: 8311645: Memory leak in jspawnhelper spawnChild after JDK-8307990

Jenny Shivayogi duke at openjdk.org
Mon Jul 10 18:31:12 UTC 2023


On Mon, 10 Jul 2023 16:38:26 GMT, Volker Simonis <simonis at openjdk.org> wrote:

>> Free-ing 'buf' before two conditional return statements introduced by JDK-8307990
>
> Hi @kspeeyu ,
> 
> Thanks for fixing this issue. The fix looks good except the whitespace issue already mentioned before.
> 
> Notice that we don't use TABs for code indentation in OpenJDK. For the native Hotspot sources (i.e. the ones under `src/hotspot/`) we use an indentation of two spaces whereas for Java code and the native part of the class library (i.e. the native code outside `src/hotspot`) we use four spaces. We don't change the indentation of imported libraries like HarfBuzz or zlib at all.
> 
> You can find more details on the coding style under https://github.com/openjdk/jdk/tree/master/doc. Just in case you haven't seen it yet, the [OpenJDK Developers’ Guide](https://openjdk.org/guide/) also contains a lot of useful information.

@simonis, thanks for your response. Fixed the whitespace, will follow the coding style guidelines.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14809#issuecomment-1629484604


More information about the core-libs-dev mailing list