RFR: 6983726: Reimplement MethodHandleProxies.asInterfaceInstance [v23]
Chen Liang
liach at openjdk.org
Tue Jul 11 13:09:00 UTC 2023
> As John Rose has pointed out in this issue, the current j.l.r.Proxy based implementation of MethodHandleProxies.asInterface has a few issues:
> 1. Exposes too much information via Proxy supertype (and WrapperInstance interface)
> 2. Does not allow future expansion to support SAM[^1] abstract classes
> 3. Slow (in fact, very slow)
>
> This patch addresses all 3 problems:
> 1. It updates the WrapperInstance methods to take an `Empty` to avoid method clashes
> 2. This patch obtains already generated classes from a ClassValue by the requested interface type; the ClassValue can later be updated to compute implementation generation for abstract classes as well.
> 3. This patch's faster than old implementation in general.
>
> Benchmark for revision 17:
>
> Benchmark Mode Cnt Score Error Units
> MethodHandleProxiesAsIFInstance.baselineAllocCompute avgt 15 1.503 ± 0.021 ns/op
> MethodHandleProxiesAsIFInstance.baselineCompute avgt 15 0.269 ± 0.005 ns/op
> MethodHandleProxiesAsIFInstance.testCall avgt 15 1.806 ± 0.018 ns/op
> MethodHandleProxiesAsIFInstance.testCreate avgt 15 17.332 ± 0.210 ns/op
> MethodHandleProxiesAsIFInstance.testCreateCall avgt 15 19.296 ± 1.371 ns/op
> MethodHandleProxiesAsIFInstanceCall.callDoable avgt 5 0.419 ± 0.004 ns/op
> MethodHandleProxiesAsIFInstanceCall.callHandle avgt 5 0.421 ± 0.004 ns/op
> MethodHandleProxiesAsIFInstanceCall.callInterfaceInstance avgt 5 1.731 ± 0.018 ns/op
> MethodHandleProxiesAsIFInstanceCall.callLambda avgt 5 0.418 ± 0.003 ns/op
> MethodHandleProxiesAsIFInstanceCall.constantDoable avgt 5 0.263 ± 0.003 ns/op
> MethodHandleProxiesAsIFInstanceCall.constantHandle avgt 5 0.262 ± 0.002 ns/op
> MethodHandleProxiesAsIFInstanceCall.constantInterfaceInstance avgt 5 0.262 ± 0.002 ns/op
> MethodHandleProxiesAsIFInstanceCall.constantLambda avgt 5 0.267 ± 0.019 ns/op
> MethodHandleProxiesAsIFInstanceCall.direct avgt 5 0.266 ± 0.013 ns/op
> MethodHandleProxiesAsIFInstanceCreate.createCallInterfaceInstance avgt 5 18.057 ± 0.182 ns/op
> MethodHandleProxiesAsIFInstanceCreate.createCallL...
Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 50 commits:
- Clean up impl comment, reorganize tests; weak ref broken
- Merge branch 'master' into explore/mhp-iface
- Fix broken null behaviors
- Merge branch 'master' into explore/mhp-iface
- Merge branch 'mh-proxies' of https://github.com/mlchung/jdk into explore/mhp-iface
- store a WeakReference holder in the class value
- Merge branch 'master' into explore/mhp-iface
- stage
Signed-off-by: liach <liach at users.noreply.github.com>
- Review comments
- Code cleanup, thanks mandy!
- ... and 40 more: https://git.openjdk.org/jdk/compare/4b1403d0...3d67ed06
-------------
Changes: https://git.openjdk.org/jdk/pull/13197/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13197&range=22
Stats: 1749 lines in 16 files changed: 1349 ins; 311 del; 89 mod
Patch: https://git.openjdk.org/jdk/pull/13197.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/13197/head:pull/13197
PR: https://git.openjdk.org/jdk/pull/13197
More information about the core-libs-dev
mailing list