RFR: 8311500: StackWalker.getCallerClass() throws UOE if invoked reflectively [v2]
Volker Simonis
simonis at openjdk.org
Tue Jul 11 15:55:14 UTC 2023
On Thu, 6 Jul 2023 07:16:19 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Volker Simonis has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Rename new parameter according to the HS coding conventions
>
> src/hotspot/share/prims/stackwalk.cpp line 501:
>
>> 499: KeepStackGCProcessedMark keep_stack(THREAD);
>> 500: numFrames = fill_in_frames(mode, stream, frame_count, start_index,
>> 501: frames_array, end_index, true, CHECK_NULL);
>
> Could you annotate the new argument please ie. `true /* first batch */` and `false /* not first batch */`. Thanks.
I've removed these arguments in the latest version.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14773#discussion_r1259939849
More information about the core-libs-dev
mailing list