RFR: 8155902: DataOutputStream writeInt creates 2 packets instead of 1 [v2]

Brian Burkhalter bpb at openjdk.org
Tue Jul 11 16:48:24 UTC 2023


On Tue, 11 Jul 2023 08:30:43 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8155902: Delete "merely"
>
> src/java.base/share/classes/java/io/DataOutputStream.java line 44:
> 
>> 42:  * the underlying output stream, hence there is no guarantee as to
>> 43:  * the details of how the bytes are written.
>> 44:  *
> 
> It might be better to expand the first paragraph of the class description to make it clearer that it wraps another output stream. Writing to the DOS will write bytes to the underlying output stream. That would give you the setup needed to explain that writing data that is more than one byte may result in several writes to the underlying output stream.

Changed accordingly in f89aa63ac2b03e66ae3f7238e4decbb0d28794de.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14791#discussion_r1259997711


More information about the core-libs-dev mailing list