RFR: 8155902: DataOutputStream writeInt creates 2 packets instead of 1 [v3]

Brian Burkhalter bpb at openjdk.org
Tue Jul 11 17:36:20 UTC 2023


On Tue, 11 Jul 2023 17:24:11 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8155902: Add verbiage to existing paragraph; remove apiNote
>
> src/java.base/share/classes/java/io/DataOutputStream.java line 37:
> 
>> 35:  * write methods of that output stream. Hence writing data consisting of
>> 36:  * more than a single byte may cause several writes to the underlying
>> 37:  * output stream.
> 
> This looks much better than the apiNote. One suggestion is to drop "Hence", I don't think it is needed here.

Dropped in 3f195664b25767305e745c91aa9ae8513fa8f9a4.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14791#discussion_r1260059053


More information about the core-libs-dev mailing list