RFR: 8311968: Clarify Three-letter time zone IDs in java.util.TimeZone [v2]

Justin Lu jlu at openjdk.org
Thu Jul 13 20:27:33 UTC 2023


On Thu, 13 Jul 2023 19:38:35 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review: update wording to include mappings
>
> src/java.base/share/classes/java/util/TimeZone.java line 135:
> 
>> 133:  * recognize one of them. The full list of the deprecated IDs and their mappings
>> 134:  * can be viewed at {@link java.time.ZoneId#SHORT_IDS}. It should be noted that
>> 135:  * not all three-letter time zone IDs are deprecated, as some come from the IANA
> 
> This is a bit confusing at least to me as I did not see which SHORT_IDS were not deprecated via the link above, but perhaps I missed it.

I see your point, the intent was that there exists three-letter time zone IDs and only the deprecated ones were at `SHORT_IDS`. I have updated the wording to explicitly clarify this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14861#discussion_r1263019145


More information about the core-libs-dev mailing list