RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v19]

[Mandy Chung]

On Wed, 5 Jul 2023 23:30:03 GMT, Oliver Kopp <duke at openjdk.org> wrote:

>> It's looking pretty good. 
>> 
>> About the test, I don't see `ArrayList::add` in the generated bytecode of `sub2-13`.   The dedup string set is used for the targets of qualified exports and opens and uses.   The modifiers set of `requires` is deduplicated but not the required module names.
>> 
>> I assume you want this be backported.  If so, we should give it some baked time after it's integrated to the main line.    I'm okay if you want to extend the test in a follow up.     You can extract the generated class to verify:
>> 
>> $ jimage extract --dir=dir out-jlink/lib/modules
>> $ javap -p -v dir/java.base/jdk/internal/module/SystemModules$all.class
>
>> It's looking pretty good.
> 
> Thank you!
> 
>> About the test, I don't see `ArrayList::add` in the generated bytecode of `sub2-13`. The dedup string set is used for the targets of qualified exports and opens and uses. The modifiers set of `requires` is deduplicated but not the required module names.
> 
> Thank you for the hint.
> 
>> I assume you want this be backported. If so, we should give it some baked time after it's integrated to the main line.
> 
> Sounds great!
> 
>> I'm okay if you want to extend the test in a follow up. 
> 
> That would be great. Will take time to craft a proper setting.

@koppor do you have any update on a new test for [JDK-8311591](https://bugs.openjdk.org/browse/JDK-8311591)?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14408#issuecomment-1636072257