RFR: 8304006: jlink should create the jimage file in the native endian for the target platform [v21]

Jaikiran Pai jpai at openjdk.org
Sun Jul 16 06:25:01 UTC 2023


On Sat, 15 Jul 2023 06:16:45 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Done. The PR has been updated with these changes.
>
> Apologies, I somehow had Files.mismatch in my head, which does compare contents. If the files exists, Files.isSameFile is semantically equivalent to checking if the real path to both is equal, so what you had on that file was correct.

Hello Alan,

> If the files exists, Files.isSameFile is semantically equivalent to checking if the real path to both is equal, so what you had on that file was correct.

I've updated the PR to use `Files.isSameFile()` like previously.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/11943#discussion_r1264615812


More information about the core-libs-dev mailing list