RFR: 8311172: Classfile.PREVIEW_MINOR_VERSION doesn't match that read from class files
Adam Sotona
asotona at openjdk.org
Mon Jul 17 07:04:56 UTC 2023
On Fri, 30 Jun 2023 13:10:55 GMT, Chen Liang <liach at openjdk.org> wrote:
> `Classfile.PREVIEW_MINOR_VERSION`, currently -1, is correct when passed to `ClassBuilder::withVersion`, but is incorrect when compared to `ClassModel::minorVersion`, which only sets the bits of 2 lowest bytes to 1 (65536). Discovered when trying to replace an asserted preview minor version with this constant in `PreviewHiddenClass` test porting in #13009, which is currently failing.
>
> Requesting a review from @asotona.
It looks good, thanks for the fix.
-------------
Marked as reviewed by asotona (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14731#pullrequestreview-1532114201
More information about the core-libs-dev
mailing list