Integrated: 8311172: Classfile.PREVIEW_MINOR_VERSION doesn't match that read from class files

Chen Liang liach at openjdk.org
Mon Jul 17 11:57:21 UTC 2023


On Fri, 30 Jun 2023 13:10:55 GMT, Chen Liang <liach at openjdk.org> wrote:

> `Classfile.PREVIEW_MINOR_VERSION`, currently -1, is correct when passed to `ClassBuilder::withVersion`, but is incorrect when compared to `ClassModel::minorVersion`, which only sets the bits of 2 lowest bytes to 1 (65536). Discovered when trying to replace an asserted preview minor version with this constant in `PreviewHiddenClass` test porting in #13009, which is currently failing.
> 
> Requesting a review from @asotona.

This pull request has now been integrated.

Changeset: 3fb9d117
Author:    Chen Liang <liach at openjdk.org>
Committer: Adam Sotona <asotona at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3fb9d117e353af6f007e701a8cd635763bd3cc28
Stats:     65 lines in 2 files changed: 64 ins; 0 del; 1 mod

8311172: Classfile.PREVIEW_MINOR_VERSION doesn't match that read from class files

Reviewed-by: asotona

-------------

PR: https://git.openjdk.org/jdk/pull/14731


More information about the core-libs-dev mailing list