RFR: 8308591: JLine as the default Console provider
Naoto Sato
naoto at openjdk.org
Mon Jul 17 17:32:15 UTC 2023
On Thu, 1 Jun 2023 18:53:21 GMT, Naoto Sato <naoto at openjdk.org> wrote:
> This is to bring the JLine-based Console implementation as the default, which was the initial intention in [JDK-8295803](https://bugs.openjdk.org/browse/JDK-8295803). A corresponding CSR has also been drafted.
Thanks, Alan.
> This looks quite good. I think Console::isTerminal works as a method name but we might have to iterate a bit on the javadoc to more clearly define it.
>
Do you think adding an `implNote` that describes the platform behavior, e.g., on Unix it is equivalent to calling `isatty(stdin/out)` and stdin/out file descriptor are valid character devices on Windows, would help?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14271#issuecomment-1638574326
More information about the core-libs-dev
mailing list