RFR: 8311663: Additional refactoring of Locale tests to JUnit [v2]
Justin Lu
jlu at openjdk.org
Mon Jul 17 21:31:33 UTC 2023
> Please review this PR which refactors more java.util.Locale tests to JUnit with some minor cleanup as well.
>
> Although some of the files could benefit from being renamed bugNNNNNNN to something more descriptive, this makes reviewing harder, and will be handled separately.
Justin Lu has updated the pull request incrementally with six additional commits since the last revision:
- Review: Explicitly run via othervm and pass locale args in cmdline
- Review: ws removal in Bug8179071.java
- Review: remove redudant 'throws'
- Review: Use assertTrue() in Bug8179071.java
- Review: Revert "Same as prev commit"
This reverts commit 933c0312ed2fa0f40a750e950c166b7e820df7ab.
- Review: Revert "Remove try catch in Bug8135061.java"
This reverts commit f213c74e37ed257a05a535b2c077af327343acb5.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/14881/files
- new: https://git.openjdk.org/jdk/pull/14881/files/933c0312..2b07e9f9
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=14881&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=14881&range=00-01
Stats: 31 lines in 4 files changed: 9 ins; 7 del; 15 mod
Patch: https://git.openjdk.org/jdk/pull/14881.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/14881/head:pull/14881
PR: https://git.openjdk.org/jdk/pull/14881
More information about the core-libs-dev
mailing list