RFR: JDK-8310913 Move ReferencedKeyMap to jdk.internal so it may be shared [v5]

Chen Liang liach at openjdk.org
Tue Jul 18 15:09:01 UTC 2023


On Thu, 6 Jul 2023 19:58:09 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Jim Laskey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add flag for reference queue type
>
> src/java.base/share/classes/jdk/internal/util/ReferencedKeyMap.java line 132:
> 
>> 130:      */
>> 131:     public static <K, V> ReferencedKeyMap<K, V>
>> 132:     create(boolean isSoft, boolean useNativeQueue, Supplier<Map<ReferenceKey<K>, V>> supplier) {
> 
> I suggest to keep the previous `create(boolean isSoft, Supplier supplier)`  factory method that defaults to non-native reference queue, which is commonly used.   Only `MethodType` needs to use native reference queue.

Mandy: The no-`NativeQueue` version is already implemented above.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14684#discussion_r1266908707


More information about the core-libs-dev mailing list