RFR: 8312019: Simplify and modernize java.util.BitSet.equals

Martin Buchholz martin at openjdk.org
Wed Jul 19 15:08:05 UTC 2023


On Thu, 13 Jul 2023 10:50:30 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> Please review this PR to use modern APIs and language features to simplify equals for BitSet. 
> 
> I couldn't see how to refactor hashCode using Arrays utility methods in a way that preserves its specification. So, aside from refactoring its doc comment and annotating it with `@Overrides`, I left it intact.

BitSet#equals again demonstrates the brittleness of inheritance - it requires subclasses of BitSet to maintain the same private representation. (don't try to fix it!)

-------------

Marked as reviewed by martin (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14868#pullrequestreview-1537320980


More information about the core-libs-dev mailing list