RFR: 8039165: [Doc] MessageFormat null locale generates NullPointerException [v4]
Naoto Sato
naoto at openjdk.org
Wed Jul 19 19:51:52 UTC 2023
On Wed, 19 Jul 2023 19:41:57 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8312197) which updates the javadoc for the constructor of MessageFormat regarding a `null` locale,
>>
>> `MessageFormat` when created with a `null` locale may throw a `NullPointerException` either during the object creation, or later when `format()` is called by the `MessageFormat` object (test file has examples of both). This change updates the specification of MessageFormat to make this apparent.
>>
>> The test for this change was merged with `Bug6481179.java` into `MessageFormatExceptions.java` (As they both test exceptions). In addition, some other exception testing regarding MessageFormat was added.
>>
>> Thanks
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>
> Account for setLocale()
LGTM
-------------
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14911#pullrequestreview-1537916353
More information about the core-libs-dev
mailing list