RFR: 8199149: Improve the exception message thrown by VarHandle of unsupported operation [v2]

[Jorn Vernee]

On Wed, 19 Jul 2023 02:19:58 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> `VarForm::getMemberName` currently throws UOE with no information if the requested access mode is unsupported.   To provide the var handle information, move the access mode check to `VarHandle` so that the exception message can include the var handle information.  Changes include:
>> 
>> 1. change `VarHandle::checkAccessModeThenIsDirect` to check if the access mode is unsupported.  This check is only needed for direct var handle.
>> 2. change `VarHandle::getMethodHandleUncached` to call `getMemberNameOrNull` and throw UOE with an informative exception message if the access mode is unsupported
>> 
>> The error message looks like:
>> 
>> java.lang.UnsupportedOperationException: compareAndSet is not supported for VarHandle[varType=java.lang.String, coord=[class Foo$Goo]]
>
> Mandy Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review feedback

> change VarHandle::checkAccessModeThenIsDirect to check if the access mode is unsupported. This check is only needed for direct var handle.

Note that `IndirectVarHandle` calls `super.checkAccessModeThenIsDirect`, so it ends up doing the check any way, I think?

src/java.base/share/classes/java/lang/invoke/VarHandle.java line 36:

> 34: import java.util.HashMap;
> 35: import java.util.List;
> 36: import java.util.Map;

These two new imports seem unused.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14928#pullrequestreview-1538189132
PR Review Comment: https://git.openjdk.org/jdk/pull/14928#discussion_r1268779284