RFR: 8312019: Simplify and modernize java.util.BitSet.equals [v2]

Martin Buchholz martin at openjdk.org
Thu Jul 20 00:07:43 UTC 2023


On Wed, 19 Jul 2023 22:08:04 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Please review this PR to use modern APIs and language features to simplify equals for BitSet. 
>> 
>> I couldn't see how to refactor hashCode using Arrays utility methods in a way that preserves its specification. So, aside from refactoring its doc comment and annotating it with `@Overrides`, I left it intact.
>
> Pavel Rappo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into 8312019
>  - Use a leaner utility method
>  - Initial commit

LGTM

-------------

Marked as reviewed by martin (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14868#pullrequestreview-1538218014


More information about the core-libs-dev mailing list