RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v10]

Viktor Klang duke at openjdk.org
Fri Jul 21 20:20:44 UTC 2023


On Fri, 21 Jul 2023 16:29:24 GMT, Doug Lea <dl at openjdk.org> wrote:

>> src/java.base/share/classes/java/util/concurrent/LinkedTransferQueue.java line 896:
>> 
>>> 894:             for (DualNode p = (pred == null) ? head : pred.next, c = p;
>>> 895:                  p != null; ) {
>>> 896:                 boolean isData = p.isData;
>> 
>> @DougLea Are you finding that manual hoisting of reads to final members has a perf edge? 🤔
>
> Collection-support code from method countOfMode on down was minimally touched from its previous version. This shows up as a style clash into very branchy self-link-coping code. Changing might require more changes to WhiteBox tests that are finicky about node counts and self-links expected in traversals etc.  (These tests are useful but are themselves hard to change to accommodate small implementation differences.)

@DougLea Alright, good to know :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14317#discussion_r1271061647


More information about the core-libs-dev mailing list