RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v5]

Sergey Bylokhov serb at openjdk.org
Tue Jul 25 23:55:00 UTC 2023


On Thu, 13 Oct 2022 14:48:29 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> The C99 snprintf is available with Visual Studio 2015 and above, alongside Windows 10 and the UCRT, and is no longer identical to the outdated Windows _snprintf. Since support for the Visual C++ 2017 compiler was removed a while ago, we can now safely remove the compatibility workaround on Windows and have JLI_Snprintf simply delegate to snprintf.
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into patch-1
>  - Merge branch 'openjdk:master' into patch-1
>  - Comment documenting change isn't required
>  - Merge branch 'openjdk:master' into patch-1
>  - Comment formatting
>  - Remove Windows specific JLI_Snprintf implementation
>  - Remove Windows JLI_Snprintf definition

Thank you!

>If processing string specifier s, S, or Z, format specification processing stops, a NULL is placed at the beginning of the buffer.

I hope this is not an MS extension/implementation detail since I did not find this in any other places.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/10625#issuecomment-1650717499


More information about the core-libs-dev mailing list