RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v5]

[Sergey Bylokhov]

On Tue, 25 Jul 2023 23:51:34 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into patch-1
>>  - Merge branch 'openjdk:master' into patch-1
>>  - Comment documenting change isn't required
>>  - Merge branch 'openjdk:master' into patch-1
>>  - Comment formatting
>>  - Remove Windows specific JLI_Snprintf implementation
>>  - Remove Windows JLI_Snprintf definition
>
> Thank you!
> 
>>If processing string specifier s, S, or Z, format specification processing stops, a NULL is placed at the beginning of the buffer.
> 
> I hope this is not an MS extension/implementation detail since I did not find this in any other places.

>@mrserb this change was to a Windows specific file.

That change removed the windows specific version of the JLI_Snprintf, and now we use
`#define JLI_Snprintf   snprintf` on all platforms. And my question was about that "cross-platform" `snprintf`. As linked in the comment above on Windows it adds the null at the start of the buffer in case of error when a negative value is returned. But is that specified by the c99?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/10625#issuecomment-1650963715