RFR: 8311653: Modify -XshowSettings launcher behavior [v3]

Mandy Chung mchung at openjdk.org
Wed Jul 26 16:30:53 UTC 2023


On Wed, 26 Jul 2023 09:22:14 GMT, Sean Coffey <coffeys at openjdk.org> wrote:

>> Modify the -XshowSettings launcher option to print non-verbose settings details of all components by default. Verbose settings details will be printed via the -XshowSettings:all option. Modify the -XshowSettings option to reject bad values passed to it. Print an error message in such scenarios and abort the VM launch.
>
> Sean Coffey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
> 
>  - Merge branch 'master' into 8311653-showSettings-tweak
>  - Incorporate changes from Mandys review
>  - Incorporate review feedback
>  - modify -X output for :all
>  - restore imports
>  - Abort if bad options input
>  - 8311653

Looks good.

Regarding the CSR, the specification change says:

> Bad options such as -XshowSettings:bad will no longer print any settings information. Instead a warning and help message is printed and the VM launch is aborted.

This should be updated as it will abort with an error message if the option is invalid.  No warning and help message is printed.

-------------

Marked as reviewed by mchung (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15001#pullrequestreview-1548154706


More information about the core-libs-dev mailing list