RFR: 8309191: Reduce JDK dependencies of cgroup support
Alan Bateman
alanb at openjdk.org
Thu Jun 1 06:19:04 UTC 2023
On Tue, 30 May 2023 13:03:27 GMT, Aleksandar Pejović <duke at openjdk.org> wrote:
> The current code for cgroup support in the JDK has large and expensive dependencies: it uses NIO, streams, and regular expressions. This leads to unnecessary class loading and slows down startup, especially when the code is executed early during an application startup. This is especially a problem for GraalVM, which executes this code during VM startup.
>
> This PR reduces the dependencies:
> - NIO is replaced with regular `java.io` for file access.
> - Streams are replaced with loops (a side effect of this is that files are read in full whereas previously they could be read up to a certain point, e.g., until a match is found).
> - Regular expressions are replaced with manual tokenization (and for usages of `String.split`, the "regex" is changed to single characters for which `String.split` has a fast-path implementation that avoids the regular expression engine).
This seems a real backward step. I think some finer grain analysis is needed to work through specific issues, e.g. maybe startup with the regex usage and report back on how much that helps.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14216#issuecomment-1571420444
More information about the core-libs-dev
mailing list