RFR: 8308090: Add container tests for on-the-fly resource quota updates [v2]
David Holmes
dholmes at openjdk.org
Thu Jun 1 06:23:07 UTC 2023
On Tue, 23 May 2023 09:04:11 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> Please review these test changes which implement automatic testing of container resource updates without JVM restart. Note that this merely tests container detection code handling this case. It doesn't do anything special for the JVM itself, though it might make sense to add some sanity checks should we detect certain limits changing. In another PR, though.
>>
>> As to the test design, it works similar to the shared temp tests: Interact between the two containers by virtue of a shared filesystem `/tmp` and creating marker files there in order to make them cooperate. Note that the new test needs `podman` version `4.3.0` and better (`4.5` is current).
>>
>> Testing:
>> - [x] GHA
>> - [x] Linux x86_64 container tests on cg v1 and cg v2 system
>> - [x] Newly added tests on Linux x86_64 cg v1 and cg v2 (`podman` and `docker`)
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Merge branch 'master' into jdk-8308090-tests-container-on-fly-updates
> - Fix whitespace
> - 8308090: Add container tests for on-the-fly resource quota updates
These tests didn't fail but I couldn't properly validate the output as we don't seem to save the process stdout file.
But I guess these are okay.
Thanks.
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14090#pullrequestreview-1454663420
More information about the core-libs-dev
mailing list