RFR: 6983726: Reimplement MethodHandleProxies.asInterfaceInstance [v17]
Chen Liang
liach at openjdk.org
Thu Jun 1 15:17:41 UTC 2023
> As John Rose has pointed out in this issue, the current j.l.r.Proxy based implementation of MethodHandleProxies.asInterface has a few issues:
> 1. Exposes too much information via Proxy supertype (and WrapperInstance interface)
> 2. Does not allow future expansion to support SAM[^1] abstract classes
> 3. Slow (in fact, very slow)
>
> This patch addresses all 3 problems:
> 1. It updates the WrapperInstance methods to take an `Empty` to avoid method clashes
> 2. This patch obtains already generated classes from a ClassValue by the requested interface type; the ClassValue can later be updated to compute implementation generation for abstract classes as well.
> 3. This patch's faster than old implementation in general.
>
>
> Benchmark Mode Cnt Score Error Units
> MethodHandleProxiesAsIFInstance.baselineAllocCompute avgt 15 1.483 ± 0.025 ns/op
> MethodHandleProxiesAsIFInstance.baselineCompute avgt 15 0.264 ± 0.006 ns/op
> MethodHandleProxiesAsIFInstance.testCall avgt 15 1.773 ± 0.040 ns/op
> MethodHandleProxiesAsIFInstance.testCreate avgt 15 16.754 ± 0.411 ns/op
> MethodHandleProxiesAsIFInstance.testCreateCall avgt 15 19.609 ± 1.598 ns/op
> MethodHandleProxiesAsIFInstanceCall.callDoable avgt 15 0.424 ± 0.024 ns/op
> MethodHandleProxiesAsIFInstanceCall.callHandle avgt 15 1.936 ± 0.008 ns/op
> MethodHandleProxiesAsIFInstanceCall.callInterfaceInstance avgt 15 1.766 ± 0.014 ns/op
> MethodHandleProxiesAsIFInstanceCall.callLambda avgt 15 0.414 ± 0.005 ns/op
> MethodHandleProxiesAsIFInstanceCall.constantDoable avgt 15 0.271 ± 0.006 ns/op
> MethodHandleProxiesAsIFInstanceCall.constantHandle avgt 15 0.263 ± 0.004 ns/op
> MethodHandleProxiesAsIFInstanceCall.constantInterfaceInstance avgt 15 0.266 ± 0.005 ns/op
> MethodHandleProxiesAsIFInstanceCall.constantLambda avgt 15 0.262 ± 0.003 ns/op
> MethodHandleProxiesAsIFInstanceCall.direct avgt 15 0.264 ± 0.005 ns/op
> MethodHandleProxiesAsIFInstanceCreate.createCallInterfaceInstance avgt 15 18.000 ± 0.181 ns/op
> MethodHandleProxiesAsIFInstanceCreate.createCallLambda ...
Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 36 additional commits since the last revision:
- Some changes per Mandy's review. SecurityManager test fails in this patch
- Merge branch 'master' into explore/mhp-iface
- Merge branch 'master' into explore/mhp-iface
- Merge branch 'master' into explore/mhp-iface
- stage, needs to fix is mh proxy instance check
- Merge branch 'master' into explore/mhp-iface
- Remove assertion, no longer true with teleport definition in MHP
- Fix tabs, and tests about modules and constructor access
- stupid faults
- Revert to shared-class implementation, found a way to deal with security manager
- ... and 26 more: https://git.openjdk.org/jdk/compare/7fb93a40...56a282e4
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/13197/files
- new: https://git.openjdk.org/jdk/pull/13197/files/bd21e68e..56a282e4
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=13197&range=16
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=13197&range=15-16
Stats: 171579 lines in 3039 files changed: 128195 ins; 20981 del; 22403 mod
Patch: https://git.openjdk.org/jdk/pull/13197.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/13197/head:pull/13197
PR: https://git.openjdk.org/jdk/pull/13197
More information about the core-libs-dev
mailing list