RFR: 8308645: Javadoc of FFM API needs to be refreshed [v4]
Jorn Vernee
jvernee at openjdk.org
Thu Jun 1 21:23:08 UTC 2023
On Thu, 1 Jun 2023 21:04:42 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> the idea behind this is to connect with the javadoc of `SymbolLookup` which defines and then uses symbol all over the place.
>
> Maybe a linkplan could help?
Okay, but `SymbolLookup` also says this: "A <em>symbol lookup</em> retrieves the address of a symbol in one or more libraries." and "This symbol lookup, which is known as a <em>default lookup</em>, helps clients to quickly find addresses of well-known symbols."
This seems to imply that "symbol" and "address" are two different things. I get the connection between the address and the SymbolLookup, but I'll note that it's also not necessary for a function address to come from a SymbolLookup (e.g. the address could be returned from native code, or be the address of an upcall stub).
So, I feel like sticking with "address" is better. Maybe a paragraph (or just a `@see` tag) could be added to refer to SymbolLookup instead?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14098#discussion_r1213693435
More information about the core-libs-dev
mailing list