RFR: JDK-8308913: Update core reflection for JEP 445 (preview)
Joe Darcy
darcy at openjdk.org
Fri Jun 2 04:51:06 UTC 2023
On Fri, 26 May 2023 20:37:39 GMT, Joe Darcy <darcy at openjdk.org> wrote:
> > > Looks fine. This version matches the current implementation where `getCanonicalName` returns non-null. When the implementation of `getCanonicalName` is updated to return null, the spec should be updated.
> > > Nit: `<p>` is needed assuming the section of "Unnamed Classes" has 3 paragraphs.
> >
> >
> > Thanks @mlchung.
> > Yes, the current spec matches what the implementation in @JimLaskey 's PR #13689 does at the time of writing.
> > Discussions are on-going with the JEP 445 team regarding whether and how to implement a "isUnnamedClass" predicate for core reflection which would allow the `getCanonicalName` method to screen for unnamed classes and return null, as would reasonably be implied by a reading of the most current draft JLS updates.
>
> PS Depending on the result of those discussion, the specification for `getCanonicalName` may be changed to return `null`.
PPS PR updated along those line; the changes will likely end up being integrated through Jim's existing JEP 445 PR.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14165#issuecomment-1573138645
More information about the core-libs-dev
mailing list